Skip to content

fix: improve error handling in searchVectorIndex method #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −5
Open

fix: improve error handling in searchVectorIndex method #750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
effc032
fix: ensure IndexReader is properly closed in searchVectorIndex method
SYaoJun Feb 28, 2026
c03960e
fix: use try-with-resources approach to avoiding exception masked
SYaoJun Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .../geaflow-store-vector/src/main/java/org/apache/geaflow/store/lucene/GraphVectorIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@ public void addVectorIndex(boolean isVertex, K key, String fieldName, float[] ve
*/
@Override
public K searchVectorIndex(boolean isVertex, String fieldName, float[] vector, int topK) {
try {
// Open index reader
IndexReader reader = DirectoryReader.open(directory);
try (IndexReader reader = DirectoryReader.open(directory)) {
IndexSearcher searcher = new IndexSearcher(reader);

// Create KNN vector query
Expand Down Expand Up @@ -166,8 +164,6 @@ public K searchVectorIndex(boolean isVertex, String fieldName, float[] vector, i
throw new IllegalArgumentException("Unsupported key type: " + keyClass.getName());
}

reader.close();

return result;
} catch (IOException e) {
throw new RuntimeException("Failed to search vector index", e);
Expand Down
Loading