Skip to content

fix(math): handle null and empty inputs in average methods #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(math): handle null and empty inputs in average methods #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions geaflow/geaflow-utils/src/main/java/org/apache/geaflow/utils/math/MathUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ private static long[] toArray(List<Long> input) {
* @return The average(values)
*/
public static long average(long[] values) {
if (values == null || values.length == 0) {
return 0;
}
//Find average
double sum = 0d;
for (long value : values) {
Expand All @@ -198,6 +201,9 @@ public static long average(long[] values) {
* @return The average(values)
*/
public static long average(List<Long> values) {
if (values == null || values.isEmpty()) {
return 0;
}
//Find average
double sum = 0d;
for (long value : values) {
Expand Down
27 changes: 27 additions & 0 deletions geaflow/geaflow-utils/src/test/java/org/apache/geaflow/utils/math/MathUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.geaflow.utils.math;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import org.testng.Assert;
Expand Down Expand Up @@ -69,6 +70,32 @@ public void testAverage() {
Assert.assertEquals(7, result);
}

@Test
public void testAverageEmptyArray() {
// Test empty array returns 0
long[] emptyArray = new long[0];
long result = MathUtil.average(emptyArray);
Assert.assertEquals(0, result);

// Test null array returns 0
long[] nullArray = null;
result = MathUtil.average(nullArray);
Assert.assertEquals(0, result);
}

@Test
public void testAverageEmptyList() {
// Test empty list returns 0
List<Long> emptyList = new ArrayList<>();
long result = MathUtil.average(emptyList);
Assert.assertEquals(0, result);

// Test null list returns 0
List<Long> nullList = null;
result = MathUtil.average(nullList);
Assert.assertEquals(0, result);
}

@Test
public void testMedian() {
List<Long> array = Arrays.asList(1L, 2L, 8L, 9L, 13L, 3L, 12L, 4L, 7L, 6L, 11L, 10L, 5L);
Expand Down