Skip to content

feat: add integration test case for flow execution#315

Open
weijinglin wants to merge 3 commits intoapache:mainfrom
hugegraph:flow_test
Open

feat: add integration test case for flow execution#315
weijinglin wants to merge 3 commits intoapache:mainfrom
hugegraph:flow_test

Conversation

@weijinglin
Copy link
Collaborator

No description provided.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 9, 2025
@github-actions github-actions bot added the llm label Dec 9, 2025
@dosubot dosubot bot added enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 9, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 18, 2025
Copy link
Member

@coderzc coderzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I reviewed this PR and found two issues that should be addressed before merge:

  1. [P1] New integration test is not executed in CI
  • File: .github/workflows/hugegraph-llm.yml (Run integration tests step)
  • test_flows_integration.py is added in this PR, but the workflow still runs only three explicit integration files. So the new tests are not part of PR checks and provide no regression protection.
  • Suggestion: include the new file in the pytest command, or switch to directory-level collection with markers.
  1. [P2] Missing external-service skip guard in new integration tests
  • File: hugegraph-llm/src/tests/integration/test_flows_integration.py
  • The tests call real flows directly (BUILD_VECTOR_INDEX / GRAPH_EXTRACT / RAG_* / TEXT2GREMLIN) without should_skip_external()-style gating or mocks. Once enabled in CI/local integration runs, they can become flaky and environment-dependent.
  • Suggestion: add explicit skip conditions for external dependencies, or stabilize with mocks/stubs for non-deterministic external calls.

Please address these and I can re-review quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request llm size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants