Skip to content

refact(store): hbase from 2.0.3 to 2.5.11 #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tsukilc wants to merge 4 commits into from
Closed

refact(store): hbase from 2.0.3 to 2.5.11 #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2c219d
refact: change hbase from 2.0.6 to 2.5.11 in pom.xml and workflow
Tsukilc Jun 11, 2025
b83449b
add license of hbase
Tsukilc Jun 15, 2025
f72313e
format
Tsukilc Jun 15, 2025
6d98439
Merge branch 'master' into hbase-2.5.11
imbajin Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/server-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,16 @@ jobs:
with:
fetch-depth: 5

# TODO: Remove this step after install-backend.sh updated
- name: Install Java8 for backend
- name: Install Java ${{ matrix.JAVA_VERSION }}
uses: actions/setup-java@v4
with:
java-version: '8'
java-version: ${{ matrix.JAVA_VERSION }}
distribution: 'zulu'

- name: Prepare backend environment
run: |
$TRAVIS_DIR/install-backend.sh $BACKEND && jps -l

- name: Install Java ${{ matrix.JAVA_VERSION }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.JAVA_VERSION }}
distribution: 'zulu'

- name: Cache Maven packages
uses: actions/cache@v4
with:
Expand Down
44 changes: 0 additions & 44 deletions hugegraph-server/hugegraph-dist/src/assembly/travis/hbase-site.xml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ case $BACKEND in
exit 1
;;
hbase)
# TODO: replace it with hbase2.3+ to avoid java8 env
"$TRAVIS_DIR"/install-hbase.sh
;;
mysql)
Expand Down
17 changes: 5 additions & 12 deletions hugegraph-server/hugegraph-dist/src/assembly/travis/install-hbase.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,18 @@ set -ev

TRAVIS_DIR=$(dirname $0)
HBASE_DOWNLOAD_ADDRESS="http://archive.apache.org/dist/hbase"
HBASE_VERSION="2.0.2"
HBASE_VERSION="2.5.11"
HBASE_PACKAGE="hbase-${HBASE_VERSION}"
HBASE_TAR="${HBASE_PACKAGE}-bin.tar.gz"

# download hbase
if [ ! -f $HOME/downloads/${HBASE_TAR} ]; then
sudo wget -q -O $HOME/downloads/${HBASE_TAR} ${HBASE_DOWNLOAD_ADDRESS}/${HBASE_VERSION}/${HBASE_TAR}
wget -q -O $HOME/downloads/${HBASE_TAR} ${HBASE_DOWNLOAD_ADDRESS}/${HBASE_VERSION}/${HBASE_TAR}
fi

# decompress hbase
sudo cp $HOME/downloads/${HBASE_TAR} ${HBASE_TAR} && tar xzf ${HBASE_TAR}
cp $HOME/downloads/${HBASE_TAR} ${HBASE_TAR} && tar xzf ${HBASE_TAR}

# using tmpfs for the Hbase data directory reduces travis test runtime
sudo mkdir /mnt/ramdisk
sudo mount -t tmpfs -o size=1024m tmpfs /mnt/ramdisk
sudo ln -s /mnt/ramdisk /tmp/hbase
# start hbase standalone
${HBASE_PACKAGE}/bin/start-hbase.sh

# config hbase
sudo cp -f $TRAVIS_DIR/hbase-site.xml ${HBASE_PACKAGE}/conf

# start hbase service
sudo ${HBASE_PACKAGE}/bin/start-hbase.sh
10 changes: 5 additions & 5 deletions hugegraph-server/hugegraph-hbase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>hugegraph-server</artifactId>
Expand All @@ -35,9 +35,9 @@
<version>${revision}</version>
</dependency>
<dependency>
<groupId>com.baidu.hugegraph</groupId>
<artifactId>hbase-shaded-endpoint</artifactId>
<version>2.0.6</version>
Comment on lines -39 to -40
Copy link
Member

@imbajin imbajin Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxxoo any context about it?

Copy link
Contributor

@zyxxoo zyxxoo Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem was the protobuf version conflict with other package
https://issues.apache.org/jira/browse/HBASE-26097

Copy link
Collaborator Author

@Tsukilc Tsukilc Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your guidance. According to my observation, in 2.5.11, hbase still uses com.google.protobuf2.5
https://github.com/apache/hbase/blob/rel/2.5.11/pom.xml#L601
https://github.com/apache/hbase/blob/rel/2.5.11/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java#L23

Copy link
Collaborator Author

@Tsukilc Tsukilc Jun 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxxoo Maybe we need to create our own hbase-shaded-endpoint like
https://github.com/hugegraph/hbase/tree/HBASE-26097 ? I can try it.

<groupId>org.apache.hbase</groupId>
<artifactId>hbase-endpoint</artifactId>
<version>2.5.11</version>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
Expand Down
50 changes: 50 additions & 0 deletions install-dist/release-docs/NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2764,3 +2764,53 @@ swagger-ui NOTICE

swagger-ui
Copyright 2020-2021 SmartBear Software Inc.


========================================================================

Apache HBase NOTICE

========================================================================

Apache HBase
Copyright 2007-2022 The Apache Software Foundation

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).

--
This product incorporates portions of the 'Hadoop' project
Copyright 2007-2009 The Apache Software Foundation
Licensed under the Apache License v2.0

--
Our Orca logo we got here: http://www.vectorfree.com/jumping-orca
It is licensed Creative Commons Attribution 3.0.
See https://creativecommons.org/licenses/by/3.0/us/
We changed the logo by stripping the colored background, inverting
it and then rotating it some.
Later we found that vectorfree.com image is not properly licensed.
The original is owned by vectorportal.com. The original was
relicensed so we could use it as Creative Commons Attribution 3.0.
The license is bundled with the download available here:
http://www.vectorportal.com/subcategory/205/KILLER-WHALE-FREE-VECTOR.eps/ifile/9136/detailtest.asp

--
This product includes portions of the Bootstrap project v3.0.0
Copyright 2013 Twitter, Inc.
Licensed under the Apache License v2.0
This product uses the Glyphicons Halflings icon set.
http://glyphicons.com/
Copyright Jan Kovařík
Licensed under the Apache License v2.0 as a part of the Bootstrap project.

--
This product includes portions of the Guava project v14 and v21, specifically
'hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java'
'hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java'
Copyright (C) 2007 The Guava Authors
Licensed under the Apache License, Version 2.0

--
This product includes portions of Jetty project, specially
'hbase-shaded-hbase-shaded-testing-util/src/main/resources/org/apache/hadoop/hbase/shaded/org/mortbay/jetty/webapp/webdefault.xml'
Loading
Loading