Skip to content

feat(server): add option for task role election#2843

Merged
Pengzna merged 3 commits intomasterfrom
feat_sailuo
Jul 31, 2025
Merged

feat(server): add option for task role election#2843
Pengzna merged 3 commits intomasterfrom
feat_sailuo

Conversation

@zyxxoo
Copy link
Contributor

@zyxxoo zyxxoo commented Jul 29, 2025

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. feature New feature labels Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.90%. Comparing base (3900cc3) to head (89b8625).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/org/apache/hugegraph/task/TaskManager.java 65.21% 8 Missing ⚠️
...n/java/org/apache/hugegraph/core/GraphManager.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2843      +/-   ##
============================================
+ Coverage     40.16%   40.90%   +0.73%     
+ Complexity      488      333     -155     
============================================
  Files           747      747              
  Lines         60163    60168       +5     
  Branches       7680     7683       +3     
============================================
+ Hits          24167    24610     +443     
+ Misses        33439    32980     -459     
- Partials       2557     2578      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 29, 2025
@zyxxoo zyxxoo requested a review from imbajin July 29, 2025 15:44
Changed the default value of the role election option to false in ServerOptions. Refactored TaskManager for improved readability, updated comments, removed unnecessary protected modifiers, and streamlined thread pool initialization and shutdown logic. Added deprecation notice for local master-worker mechanism.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2025
@imbajin imbajin changed the title feat: add switch for role election feat(server): add option for task role election Jul 30, 2025
@Pengzna Pengzna merged commit 0946d5d into master Jul 31, 2025
14 of 15 checks passed
@Pengzna Pengzna deleted the feat_sailuo branch July 31, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

3 participants