chore(server): remove outdated ConfigAuthenticator#2915
Closed
ChoHee15 wants to merge 1 commit intoapache:masterfrom
Closed
chore(server): remove outdated ConfigAuthenticator#2915ChoHee15 wants to merge 1 commit intoapache:masterfrom
ChoHee15 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated ConfigAuthenticator class and all related configuration options, simplifying the authentication system to focus on the StandardAuthenticator implementation. The changes eliminate outdated token-based authentication in favor of the password-based approach.
Key Changes
- Removed
ConfigAuthenticatorclass and all references to it across the codebase - Eliminated
AUTH_ADMIN_TOKENandAUTH_USER_TOKENSconfiguration options - Updated documentation and configuration files to reflect StandardAuthenticator as the recommended authenticator
- Migrated
GraphManagerto useADMIN_PA(admin password) instead ofAUTH_ADMIN_TOKEN
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hugegraph-struct/src/main/java/org/apache/hugegraph/options/AuthOptions.java | Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS config options; removed unused ConfigListOption import; updated AUTHENTICATOR description |
| hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh | Updated sed command to use auth.admin_pa instead of auth.admin_token |
| hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties | Removed ConfigAuthenticator references and related config options from comments |
| hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/config/AuthOptions.java | Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS config options; updated AUTHENTICATOR description |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java | Changed to use ServerOptions.ADMIN_PA instead of AUTH_ADMIN_TOKEN for admin user initialization |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java | Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS; corrected ADMIN_PA description; updated AUTHENTICATOR description |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeFactoryAuthProxy.java | Removed ConfigAuthenticator from reflection filters and private action registrations |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/ConfigAuthenticator.java | Deleted entire deprecated ConfigAuthenticator class file |
| hugegraph-cluster-test/hugegraph-clustertest-dist/src/assembly/static/conf/rest-server.properties.template | Updated comments to remove ConfigAuthenticator references and added auth.admin_pa documentation |
| docker/configs/server3-conf/rest-server.properties | Updated authentication config comments to reflect StandardAuthenticator as default option |
| docker/configs/server2-conf/rest-server.properties | Updated authentication config comments to reflect StandardAuthenticator as default option |
| docker/configs/server1-conf/rest-server.properties | Updated authentication config comments to reflect StandardAuthenticator as default option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
Member
|
close by #2927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
ConfigAuthenticatoris now deprecated, and this PR removes the related content.Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need