Skip to content

chore(server): remove outdated ConfigAuthenticator#2915

Closed
ChoHee15 wants to merge 1 commit intoapache:masterfrom
hugegraph:remove_config_auth
Closed

chore(server): remove outdated ConfigAuthenticator#2915
ChoHee15 wants to merge 1 commit intoapache:masterfrom
hugegraph:remove_config_auth

Conversation

@ChoHee15
Copy link
Contributor

@ChoHee15 ChoHee15 commented Dec 2, 2025

Purpose of the PR

ConfigAuthenticator is now deprecated, and this PR removes the related content.

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 2, 2025
@imbajin imbajin requested a review from Copilot December 3, 2025 03:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated ConfigAuthenticator class and all related configuration options, simplifying the authentication system to focus on the StandardAuthenticator implementation. The changes eliminate outdated token-based authentication in favor of the password-based approach.

Key Changes

  • Removed ConfigAuthenticator class and all references to it across the codebase
  • Eliminated AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS configuration options
  • Updated documentation and configuration files to reflect StandardAuthenticator as the recommended authenticator
  • Migrated GraphManager to use ADMIN_PA (admin password) instead of AUTH_ADMIN_TOKEN

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hugegraph-struct/src/main/java/org/apache/hugegraph/options/AuthOptions.java Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS config options; removed unused ConfigListOption import; updated AUTHENTICATOR description
hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh Updated sed command to use auth.admin_pa instead of auth.admin_token
hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties Removed ConfigAuthenticator references and related config options from comments
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/config/AuthOptions.java Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS config options; updated AUTHENTICATOR description
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java Changed to use ServerOptions.ADMIN_PA instead of AUTH_ADMIN_TOKEN for admin user initialization
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java Removed AUTH_ADMIN_TOKEN and AUTH_USER_TOKENS; corrected ADMIN_PA description; updated AUTHENTICATOR description
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeFactoryAuthProxy.java Removed ConfigAuthenticator from reflection filters and private action registrations
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/ConfigAuthenticator.java Deleted entire deprecated ConfigAuthenticator class file
hugegraph-cluster-test/hugegraph-clustertest-dist/src/assembly/static/conf/rest-server.properties.template Updated comments to remove ConfigAuthenticator references and added auth.admin_pa documentation
docker/configs/server3-conf/rest-server.properties Updated authentication config comments to reflect StandardAuthenticator as default option
docker/configs/server2-conf/rest-server.properties Updated authentication config comments to reflect StandardAuthenticator as default option
docker/configs/server1-conf/rest-server.properties Updated authentication config comments to reflect StandardAuthenticator as default option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

@imbajin
Copy link
Member

imbajin commented Jan 4, 2026

close by #2927

@imbajin imbajin closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants