Skip to content

fix(pd): pd raft-follower failed to get leader address due to npe #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VGalaxies merged 1 commit into from
Dec 17, 2025
Merged

fix(pd): pd raft-follower failed to get leader address due to npe #2919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/raft/RaftRpcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public synchronized boolean init(final RpcOptions rpcOptions) {
private <V> void internalCallAsyncWithRpc(final Endpoint endpoint,
final RaftRpcProcessor.BaseRequest request,
final FutureClosureAdapter<V> closure) {
final InvokeContext invokeCtx = null;
final InvokeContext invokeCtx = new InvokeContext();
final InvokeCallback invokeCallback = new InvokeCallback() {
Comment on lines +63 to 64
Copy link
Member

@imbajin imbajin Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any context for it? And we should add some basic tests to ensure the logic right

Copy link
Contributor Author

@JisoLya JisoLya Dec 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation throws a NullPointerException (NPE) when performing cluster tests on a 3-node PD setup (see image).
Follower side:
image

Leader side (which has no any dbCompaction log):
image

The issue is reproducible with this test code:

@Test
    public void TestSimplePd() throws PDException {
		// 8686: leader, 8688 and 8687 are followers
        String addr = "127.0.0.1:8687";
        PDConfig pdConfig = PDConfig.of(addr);
        PDClient client = PDClient.create(pdConfig);
        client.dbCompaction();
    }

Send dbCompaction to followers after changes:
Follower side log:
image
Leader side log which is expected:
image


@Override
Expand Down
Loading