feat: implement delete file index #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
force-pushed
the
delete_file_index
branch
from
a23aa2b to
67d3b69
Compare
HuaHuaY
reviewed
Dec 24, 2025
wgtmac
force-pushed
the
delete_file_index
branch
4 times, most recently
from
9345afc to
0b8f579
Compare
HuaHuaY
reviewed
Dec 25, 2025
wgtmac
force-pushed
the
delete_file_index
branch
from
0b8f579 to
5cd132b
Compare
zhjwpku
approved these changes
Dec 26, 2025
| // select record_count, which is a primitive type. | ||
| if (!columns.empty()) { | ||
| const std::unordered_set<std::string_view> selected(columns.cbegin(), columns.cend()); | ||
| if (selected.contains(ManifestReader::kAllColumns)) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (selected.contains(ManifestReader::kAllColumns)) { | |
| if (selected.contains(Schema::kAllColumns)) { |
| "upper_bounds", "record_count"}; | ||
| const std::vector<std::string> kStatsColumns = { | ||
| "value_counts", "null_value_counts", "nan_value_counts", "lower_bounds", | ||
| "upper_bounds", "column_sizes", "record_count"}; |
Collaborator
There was a problem hiding this comment.
The newly added column_sizes seems not aligned with java impl, is that a bug in java or our implementation is different?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the DeleteFileIndex and Builder to manage and efficiently filter
delete files (equality deletes, position deletes, and deletion vectors)
based on sequence numbers and partitions.
Key changes:
DeleteFileIndexandDeleteFileIndex::Builderinsrc/iceberg/delete_file_index.{h,cc}.ContentFileUtilfor helper functions related to content files and DVs.ManifestReaderto support dropping stats viaTryDropStats().src/iceberg/test/delete_file_index_test.cc.