feat: table overwrite functionality #674
Open
+506
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontirun
commented
Jan 9, 2026
Comment on lines
+693
to
+700
| metadata: meta, | ||
| fs: fs, | ||
| projectedSchema: t.meta.CurrentSchema(), | ||
| boundRowFilter: boundFilter, | ||
| caseSensitive: true, | ||
| rowLimit: -1, // No limit | ||
| concurrency: 1, | ||
| } |
Author
There was a problem hiding this comment.
I don't know if this is correct
Member
|
I'll give this a look to start reviewing, in the meantime can you fix the lint issues? |
Contributor
|
This requires the replacing table to match the schema of the replaced table, right? Asking since I'm interested in something like |
Author
Yes |
Member
|
The spark integration tests for overwrite don't seem to be passing |
Author
I definitely didn't do those correctly, any guidance on whether they're structured fine or if I'm going about it the right way? I couldn't figure out testing it locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668
There are quite a few things I'm not too sure about with this implementation (like the filtering logic or if I've properly tested it)