Skip to content

Conversation

@Thespica
Copy link
Contributor

Reason for this PR

close #693

What changes are included in this PR?

edit spark ci file, and upgrade ubuntu version of GitHub action runner

Are these changes tested?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.65%. Comparing base (ba30326) to head (9cce90a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #694      +/-   ##
============================================
+ Coverage     59.94%   66.65%   +6.70%     
- Complexity        0      226     +226     
============================================
  Files            65       21      -44     
  Lines          9213     2012    -7201     
  Branches        975      179     -796     
============================================
- Hits           5523     1341    -4182     
+ Misses         3690      515    -3175     
- Partials          0      156     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jobs:
test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's a specific reason not to, I tend to go with the ubuntu-latest label.

@SemyonSinchenko
Copy link
Member

Both Spark 3.2 and 3.3 are not maintained anymore. What do you think about dropping them instead of trying to fix the failing CI on a newer Ubuntu containers?

@Thespica
Copy link
Contributor Author

Both Spark 3.2 and 3.3 are not maintained anymore. What do you think about dropping them instead of trying to fix the failing CI on a newer Ubuntu containers?

Thanks for your suggestion @SemyonSinchenko . I agree with you.

@Thespica
Copy link
Contributor Author

Thespica commented May 30, 2025

It seems that ci run failed because of cannot access class sun.nio.ch.DirectBuffer.

And it seems happen in Java17, but our ci test run on Java11:

- name: Run test
working-directory: maven-projects/spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}

Maybe we should set the VM option --add-exports java.base/sun.nio.ch=ALL-UNNAMED to allow that?

@SemyonSinchenko
Copy link
Member

I think it should be something like

"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
"--add-opens=java.base/java.lang=ALL-UNNAMED"
"--add-opens=java.base/java.nio=ALL-UNNAMED"
"--add-opens=java.base/java.lang.invoke=ALL-UNNAMED"
"--add-opens=java.base/java.util=ALL-UNNAMED"

@yangxk1
Copy link
Contributor

yangxk1 commented Jun 19, 2025

Hi @Thespica ,It may help to change

       export MAVEN_OPTS="--add-exports java.base/sun.nio.ch=ALL-UNNAMED

to

       export JDK_JAVA_OPTIONS="--add-opens=java.base/sun.nio.ch=ALL-UNNAMED  \
        --add-opens=java.base/java.lang=ALL-UNNAMED                           \
        --add-opens=java.base/java.nio=ALL-UNNAMED                            \
        --add-opens=java.base/java.lang.invoke=ALL-UNNAMED                    \
        --add-opens=java.base/java.util=ALL-UNNAMED"

image

@Thespica
Copy link
Contributor Author

@SemyonSinchenko @yangxk1 this PR is ready, please take a review : )

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~LGTM, nice work!

@Thespica Thespica merged commit eb4984d into apache:main Jun 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): upgrade ubuntu version of GitHub action runner

5 participants