Skip to content

Conversation

@netomi
Copy link
Member

@netomi netomi commented Mar 25, 2025

This PR proposes the following changes:

  • remove hack wrt __main__.__file__ to determine the app dir
  • support an app_dir kw arg to override the app directory if needed, defaults to the cwd
  • pop asfquart specific kw args prior to calling super.init as quart panics otherwise
  • add a runx_from_config method to support running hypercorn with a config file

That allows to run asfquart with a hypercorn config file to set various settings that would otherwise not be possible, e.g. --reload.

@netomi netomi marked this pull request as draft March 25, 2025 20:24
@netomi
Copy link
Member Author

netomi commented Mar 25, 2025

Not sure about the runx_from_config method anymore. My idea was to have a way to run an asfquart in development mode. For that the watch mechanism is not useful at all, looking for other ways to support that.

@netomi netomi closed this Apr 4, 2025
@netomi netomi deleted the graceful-setup branch April 4, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant