After surefire 2058

[Tibor17]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[zoltanmeze]

What's the reason of resetting line position here?

Will give this branch a try later. Maybe compare events dump before and after on single test runs, and just see if larger projects have no other issues.

I think I already tried with removed do-while once, because it was suspicious at first look. But didn't want to change anything else in #518 , but my guess was that that wile condition is never true.

[Tibor17]

@zoltanmeze memento.getLine() holds the line which could not be properly decoded and it is eligible for printing a corruption status on the console.

[Tibor17]

After properly decoded bytes, we clear the buffer and new bytes will be decoded. The corrupted line has to reset to 0 and remaining is 0 too of course.

[Tibor17]

If MalformedFrameException is caught, whole byte sequence is printed as a corrupted string starting by memento.getLine().getPositionByteBuffer() up to the buffer's position.

[zoltanmeze]

I see. Wouldn't read( memento, bytesToRead ); also reset this to 0 in every iteration starting from second?

[Tibor17]

The memento holds the reference to the buffer too. And if I clean it up, I should reset the position variable via memento.getLine().setPositionByteBuffer( 0 ) in order to be consistent.