Mention toolchains limitations in docs#672
Open
mfussenegger wants to merge 1 commit intoapache:masterfrom
Open
Mention toolchains limitations in docs#672mfussenegger wants to merge 1 commit intoapache:masterfrom
mfussenegger wants to merge 1 commit intoapache:masterfrom
Conversation
If forkCount is configured the test goal can fail with a
UnsupportedClassVersionError
Apparently this is by design:
https://issues.apache.org/jira/browse/SUREFIRE-720?focusedCommentId=16395576&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16395576
The documentation should mention a limitation like that.
Comment on lines
+39
to
+41
| Note that options like <<<forkCount>>> prevent the toolchains from being used. | ||
| See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information. | ||
|
|
Member
There was a problem hiding this comment.
Instead of pointing issue - I would like to see description how forkCount option impact on toolchains.
Reading issue and all comments is not easy to find clue of problem.
Author
There was a problem hiding this comment.
Isn't
Note that options like <<>> prevent the toolchains from being used.
describing the impact?
I'm not familiar with the exact details why it is not working. If you expect that then someone else has to make the changes.
I'd think this is at least an improvement over the status quo, because currently it says that surefire picks up toolchains by default, while it doesn't if forkCount is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If forkCount is configured the test goal can fail with a
UnsupportedClassVersionError
Apparently this is by design:
The documentation should mention a limitation like that.