Prep for a 2.3.11 release #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ches servlet path" This reverts commit 9d7caac.
Contributor
Author
|
@werpu CTS passed with this PR. Could you double check the JS files? I hope to get a release started soon. Thanks! :) |
melloware
approved these changes
Jan 3, 2025
volosied
changed the title
volosied
changed the title
pnicolucci
approved these changes
Jan 3, 2025
Contributor
pnicolucci
left a comment
pnicolucci
left a comment
There was a problem hiding this comment.
This seems reasonable to me to revert some of these for now that were done while developing Faces 4.0. This allows more time to have discussions and still get a new release out which is long over due.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 Changes Identified
MYFACES-4524 breaks the TCK since it's testing the incorrect behavior, but I don't know how to update the TCK. I created a challenge here -
https://github.com/jakartaee/faces/issues/1976node.getAttributegives me errors when I run the TCK, so I've added a check to try to avoid the error.Assert over Assertions
Reverts breaking changes (listed under MYFACES-4705)