MYFACES-4726 [5.0.x] Use SHA256DRBG as default psuedo-random generator #912
+138
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volosied
changed the title
volosied
force-pushed
the
MYFACES-4726-50X
branch
from
6612311 to
c7925c0
Compare
Contributor
Author
|
Conflicts...? I'll have to look at them. |
The new defaults will be "SHA256DRBG","DRBG", "SHA1PRNG". They are in order of priority. This is backwards compatible since previous versions only allowed one option.
volosied
force-pushed
the
MYFACES-4726-50X
branch
from
c7925c0 to
6afcba5
Compare
volosied
commented
Aug 18, 2025
| * Sets the random algorithm to initialize the secure random id generator. | ||
| * By default is SHA1PRNG | ||
| * The default is SHA256DRBG,DRBG,SHA1PRNG (in order of priority). | ||
| * The "SHA256DRBG,DRBG, and SHA1PRNG" options were introduced in 4.1.2. |
Contributor
Author
There was a problem hiding this comment.
5.0 isn't released, so I'll keep the 4.1.2 tag here.
Contributor
Author
|
SHA256DRBG is not available on all JDKs. I don' think it should be the default. SHA1PRNG is still used by Tomcat, so I think there's no rush to move to something stronger just yet. Closing this for now, but perhaps we can revisit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting as the default for 5.0
https://issues.apache.org/jira/browse/MYFACES-4726