Closed
Conversation
michal-narajowski
force-pushed
the
memfault
branch
5 times, most recently
from
51c8da2 to
81b0a8a
Compare
michal-narajowski
force-pushed
the
memfault
branch
4 times, most recently
from
6bbb4df to
05611ff
Compare
michal-narajowski
changed the title
michal-narajowski
requested review from
andrzej-kaczmarek,
ccollins476ad and
kasjer
michal-narajowski
force-pushed
the
memfault
branch
from
05611ff to
6be6ef8
Compare
RAT Report (2020-05-26 14:50:58)New files with unknown licenses
22 new files were excluded from check (.rat-excludes)Detailed analysisNew files in this PR |
Style check summaryOur coding style is here!sys/memfault/src/memfault_platform_core.cDetails@@ -42,7 +42,7 @@
* }
*/
static uint8_t s_reboot_tracking[MEMFAULT_REBOOT_TRACKING_REGION_SIZE]
- __attribute__((section(".mflt_reboot_info")));
+__attribute__((section(".mflt_reboot_info")));
static struct os_callout metrics_callout;
static uint32_t metrics_period_sec; |
kasjer
reviewed
May 30, 2020
Contributor
kasjer
left a comment
kasjer
left a comment
There was a problem hiding this comment.
There are pieces missing to do the review.
| /* Note: MCU reset reason register bits are usually "sticky" and | ||
| * need to be cleared. | ||
| */ | ||
| NRF_POWER->RESETREAS |= NRF_POWER->RESETREAS; |
Contributor
There was a problem hiding this comment.
On memfault page they claim that not only Nordic is supported. Is our implementation is limited to NRF?
| uint64_t | ||
| memfault_platform_get_time_since_boot_ms(void) | ||
| { | ||
| return (uint64_t) (os_get_uptime_usec() / 1000); |
Contributor
There was a problem hiding this comment.
cast here seems superfluous
| metrics_callout_cb, NULL); | ||
| SYSINIT_PANIC_ASSERT(metrics_callout.c_evq != NULL); | ||
|
|
||
| const sResetBootupInfo reset_reason = { |
Contributor
There was a problem hiding this comment.
variables are declared all over the place in this function
| - "@mcuboot/boot/bootutil" | ||
|
|
||
| pkg.deps.MEMFAULT_MGMT: | ||
| - "@apache-mynewt-mcumgr/cmd/memfault_mgmt" |
Author
|
Depends on these pull requests: |
Contributor
|
@michal-narajowski @andrzej-kaczmarek Perhaps we can close this out too since we have decided a path forward now ? |
Author
|
Closing since this feature has been added to memfault repo as a newt package: https://github.com/memfault/memfault-firmware-sdk/tree/master/ports/mynewt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://memfault.com/