Open
Conversation
mkasenberg
force-pushed
the
add-ipc
branch
2 times, most recently
from
0a83fa5 to
5628aad
Compare
mkasenberg
changed the title
mkasenberg
force-pushed
the
add-ipc
branch
2 times, most recently
from
9c45740 to
2ad67cf
Compare
| Adds default MPU configuration package | ||
| value: 0 | ||
|
|
||
| IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT: |
Contributor
There was a problem hiding this comment.
Looks like IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT is already defined in drivers/ipc_nrf5340/syscfg.yml. Shouldn't this be removed from there? Otherwise we'll have two duplicated definition.
First step before adding IPC ICBMsg transport support, which might help compare the changes made.
Contributor
Author
|
Just rebased |
Tested with nRF5340.
andrzej-kaczmarek
requested changes
Aug 14, 2025
Contributor
andrzej-kaczmarek
left a comment
andrzej-kaczmarek
left a comment
There was a problem hiding this comment.
As in NimBLE, I think this should be simply a ipc_icbmsg. We don't have IPC subsystem so there's no point in creating Zephyr-like structure for a simple driver.
Also please split this a bit so driver code is not mixed with BSP changes etc. unless really required to build properly when bisecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.