HDDS-13555. Remove redundant field for metrics registry #9456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @0lai0 for working on this. Please check PMD failure: https://github.com/0lai0/ozone/actions/runs/20005708495/job/57367989254 |
Contributor
Author
|
Sure, Thanks @adoroszlai for review. I think there is a lot failure I need to modify. |
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
adoroszlai
reviewed
Jan 7, 2026
Comment on lines
+33
to
+34
| @SuppressWarnings("PMD.SingularField") | ||
| protected MetricsRegistry registry; |
Contributor
There was a problem hiding this comment.
This causes checkstyle and findbugs failure.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/BaseMetricsSource.java
34: Variable 'registry' must be private and have accessor methods.
M D UuF: Unused public or protected field: org.apache.hadoop.hdds.utils.BaseMetricsSource.registry In BaseMetricsSource.java
Also, please try not to add suppression in new code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove Redundant Metrics Registry.
Refactor the code to delete the private MetricsRegistry registry; variable and remove its initialization logic from the constructor or init() method.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13555