-
Notifications
You must be signed in to change notification settings - Fork 1.2k
enhance some test method to LanceFileFormatTest class #6894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hashmapybx
wants to merge
115
commits into
apache:master
Choose a base branch
from
hashmapybx:rocky-lance-test_1.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when enable dv. (apache#6531)
(cherry picked from commit 4f9f28e)
(cherry picked from commit 3c3ba1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue:
This PR enhances the test coverage for the Lance file format implementation in Paimon. The changes include:
Fix compilation errors: Corrected incorrect usage of generic parameters for FileWriter interface
Comprehensive test coverage: Added 14 new test methods covering:
Documentation improvements: Added descriptive comments for all test methods to improve code readability and maintainability
Tests
LanceFileFormatTestunit tests inpaimon-lance/src/test/java/org/apache/paimon/format/lance/LanceFileFormatTest.javaAll 16 test methods verify:
testCreateReaderFactory- Basic reader factory creationtestCreateWriterFactory- Basic writer factory creationtestValidateDataFields_UnsupportedType_Map- Validation rejects MAP typetestValidateDataFields_UnsupportedType_LocalZonedTimestamp- Validation rejects TIMESTAMP_WITH_LOCAL_TIME_ZONEtestValidateDataFields_SupportedTypes_Basic- Basic supported types validationtestValidateDataFields_AllNumericTypes- All numeric types validationtestValidateDataFields_AllStringTypes- All string/binary types validationtestValidateDataFields_TimeTypes- Time types with different precisionstestValidateDataFields_ComplexTypes- Arrays, multisets, and variantstestValidateDataFields_NestedRowType- Nested structurestestReaderFactory_WithProjectedTypes- Column pruning scenariostestReaderFactory_BatchSizeConfiguration- Batch size configurationtestWriterFactory_BatchSizeConfiguration- Writer batch and memory configurationtestValidateDataFields_EmptyRowType- Edge case: empty RowTypetestValidateDataFields_SingleFieldTypes- Single field type scenariostestValidateDataFields_MixedArrayTypes- Mixed array element typestestValidateDataFields_VariantType- VARIANT type supportAPI and Format
No. This change only affects test code and does not modify any public APIs or storage formats.
Documentation
No. This is a test enhancement with no new features introduced.