Skip to content

Conversation

@isper3at
Copy link
Contributor

@isper3at isper3at commented Oct 1, 2018

Description

What Changed?

Merging existing content into master. Already reviewed and merged into 3.x

@isper3at isper3at force-pushed the RYA-135_collectionName branch from 3593c53 to f9691c7 Compare October 1, 2018 15:22
@asfgit
Copy link

asfgit commented Oct 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/779/

There is no need for the triples collection to be configurable, as
only the mongo database name will change the rya instance.
@isper3at isper3at force-pushed the RYA-135_collectionName branch from f9691c7 to c7406d7 Compare October 1, 2018 16:48
@asfgit
Copy link

asfgit commented Oct 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/780/

@asfgit
Copy link

asfgit commented Oct 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/781/

Build result: FAILURE

[...truncated 92.71 MB...][INFO] ------------------------------------------------------------------------[INFO] Total time: 01:06 h[INFO] Finished at: 2018-10-01T17:56:20+00:00[INFO] Final Memory: 418M/2808M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project rya.kafka.connect.mongo: Compilation failure[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/kafka.connect/mongo/src/main/java/org/apache/rya/kafka/connect/mongo/MongoRyaSinkTask.java:[106,18] cannot find symbol[ERROR] symbol: method setMongoDBName(java.lang.String)[ERROR] location: variable ryaConfig of type org.apache.rya.mongodb.MongoDBRdfConfiguration[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.kafka.connect.mongochannel stoppedSetting status of c7406d7 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/781/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing


// MongoDB Database values.
public static final String MONGO_DB_NAME = "mongo.db.name";
public static final String RYA_INSTANCE_NAME = "mongo.db.name";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this field should be renamed. It's still the Mongo DB Name. Elsewhere in the code we should decide that the rya instance name also happens to be the db name. If this is in fact just the instance name, and the DB name isn't allowed to be configured anymore, then the field's value shouldn't be "mongo.db.name" anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants