RYA-532 Assign specific interface types for Subject, Predicate, Object and Context and just generally clean up the code. #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…readingBehavior.IMMUTABLE) per the advice at https://dev-aux.com/java/org-apache-http-annotation-threadsafe-class-not-found
…t and Context and just generally clean up the code.
2 tasks
Author
|
You can see the diff without the noise of the other PR here: brushworth#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is the result of a few months worth of work to evaluate Rya for my organization. I have created this pull request to refactor Rya in small ways and to generally tidy up the code in a way that makes no functional changes. I've tried really hard to only include changes that are uncontroversial and generally applicable. Most of these changes are simply code formatting, import statement reordering and comment fixing.
I've migrated Rya data types such as RyaIRI and RyaType classes so they now inherit from RDF4J types IRI and Value respectively. I've created corresponding Rya classes for all RDF4J types, so that all terminology is now aligned between Rya and RDF4J. I've updated the RdfToRyaConversions and RyaToRdfConversions classes and implemented the required RDF4J methods on Rya types. Note that you still cannot mix and match RDF4J and Rya classes, because methods like equals() and hashCode() will not be true, since Rya types encode extra properties like column qualifiers, visibilities, timestamps, etc. That isn't really any different from how it already is, but it might change in a future pull request.
This pull request is foundational for the future pull requests I will be submitting. This pull request aims to introduce no new features. I will submit new features and fixes one at a time... but building from the code baseline in this PR.
Please note this PR builds upon #315 so you need to take that into account when reviewing the diff. When 315 is merged in, this diff will be simplified.
Tests
All existing tests remain. I added tests in a few places (e.g. RangeBindingSetEntriesTest) where they were missing. For new code written, such as in RyaToRdfConversions, I have written new tests.
Links
Jira
Checklist
People To Review
@adinancr
@jdasch