Fix Valgrind uninitialized memory warnings #12806
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
force-pushed
the
fix_valgrind_regression_tests_reports
branch
from
2e93317 to
cdeb457
Compare
Valgrind reported some uses of uninitialized memory when running the
regression tests under it. This patch addresses the following valgrind
reported issues:
1. LogBuffer flush:
Syscall param write(buf) points to uninitialised byte(s)
at Log::flush_thread_main(void*)
by LogBuffer::LogBuffer(LogConfig const*, LogObject*, ...)
2. Cache test pwrite:
Syscall param pwrite64(buf) points to uninitialised byte(s)
at AIOThreadInfo::aio_thread_main(AIOThreadInfo*)
by Stripe::Stripe(CacheDisk*, long, long, int, int)
bneradt
force-pushed
the
fix_valgrind_regression_tests_reports
branch
from
cdeb457 to
1c00d38
Compare
masaori335
approved these changes
Jan 14, 2026
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
Nice catch. Both memories are just allocated and not initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind reported some uses of uninitialized memory when running the
regression tests under it. This patch addresses the following valgrind
reported issues:
LogBuffer flush:
Syscall param write(buf) points to uninitialised byte(s)
at Log::flush_thread_main(void*)
by LogBuffer::LogBuffer(LogConfig const*, LogObject*, ...)
Cache test pwrite:
Syscall param pwrite64(buf) points to uninitialised byte(s)
at AIOThreadInfo::aio_thread_main(AIOThreadInfo*)
by Stripe::Stripe(CacheDisk*, long, long, int, int)