-
Notifications
You must be signed in to change notification settings - Fork 142
Add a section on "Expedited Releases" to the Release Policy #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
markt-asf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just the one trivial nit with the proposed text.
content/legal/release-policy.md
Outdated
|
|
||
| Release votes SHOULD remain open for at least 72 hours. | ||
| Release votes SHOULD remain open for at least 72 hours. See | ||
| [RFC 2119](https://www.rfc-editor.org/rfc/rfc2119) for a good definition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering mentioning this at the beginning of this page, since we use the keywords throughout the whole page. Or we can leave the whole reference to RFC-2119 to a follow-up since the explained content here already implies that such a "72 hours" SHOULD can be broken in exceptional circumstances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a good point and there are other policy docs also using SHOULD, I wondered the same, but just focusing on this issue and the debates it seemed a good idea to have it close to this wording. Lets see if anyone else agrees with you before deciding whether to remove it from this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah .. It would be OK to improve the reference in a follow-up also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the top of the page would be better I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've removed the reference to RFC 2119 for the definition of SHOULD. I'll leave it to someone else to decide how/where to improve the docs with that and keep this change focused only on the reduced voting period change
Co-authored-by: Arnout Engelen <arnout@engelen.eu>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…(remove SHOULD definition)
|
+1 |
|
Waiting for @rvs review |
rvs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ship it!
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
|
LGTM |
You were who I was waiting for. :) |
|
Great, thanks Everyone! |
|
Nice! |
|
I have a more concise proposal at PR #462 - sorry that I missed this discussion earlier. |
* SHA-1 is deprecated (#452) * Improve reference to voting rules from the voting process page (#441) Signed-off-by: tison <wander4096@gmail.com> * Update styles.css * Fixed the issue 412 ->Focus to glyphicon-search with necesaary delay (#455) (#456) Co-authored-by: Imvedansh <113465074+Imvedansh@users.noreply.github.com> Co-authored-by: Imvedansh <ved17007@gmail.com> * Update README.md * Fix bad link (#454) * Clarify calendar change info * Update index.md * Update members.md Fixes #459 * Update leadership.ezmd - Tooling is a Corporate Officer (#461) * Update to latest version of pagefind (#445) * Experiment with pagefind 1.3.0 * Trigger build * Trigger build * Trigger build * Trigger build * Sync with main (#442) * Trigger build * Add Cargurus, Update netapp instaclustr, Remove Cerner and Aetna. * Fix netapp image name * Update verification.md (#434) * += ECMA Relations (#435) * Add template for sending a PMC roll call (#437) * Add te,plate for sending a PMC roll call * Formatting and suggested mail headers * weird stray whitespace * Update Apache STeVe repo link to GitHub location * add apache nifi (#433) * Fix formatting * Add info on site build [skip ci] * OF: docn re featured projects * PMC Roll call text tweaks for consistency (#438) * PMC Roll call text tweaks for consistency * Grammar --------- Co-authored-by: Sebb <sebbASF@users.noreply.github.com> --------- Co-authored-by: bob <bob@apache.org> Co-authored-by: Andrew Wetmore <andrew@cottage14.com> Co-authored-by: Rich Bowen <rbowen@rcbowen.com> Co-authored-by: Shane Curcuru <asf@shanecurcuru.org> Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: Mark Thomas <markt@apache.org> * Dummy change to trigger build * Update to jquery 3.7.1 * Dummy change * Dummy change 2 * Dummy change 3 * Dummy change 4 * Bump --------- Co-authored-by: bob <bob@apache.org> Co-authored-by: Andrew Wetmore <andrew@cottage14.com> Co-authored-by: Rich Bowen <rbowen@rcbowen.com> Co-authored-by: Shane Curcuru <asf@shanecurcuru.org> Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: Mark Thomas <markt@apache.org> * Update to jquery 3.7.1 (#443) * Update members.md * Update members.md * Update members.md * Update gopidesu to members.md * Add a section on "Expedited Releases" to the Release Policy (#457) * Add a section on "Expedited Releases" to the Release Policy * Feedback on "Expedited Releases" change from raboof Co-authored-by: Arnout Engelen <arnout@engelen.eu> * Feedback on "Expedited Releases" change from potiuk Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Feedback on "Expedited Releases" change from sebbASF * Feedback on "Expedited Releases" change from markt-asf * Feedback on "Expedited Releases" change from @tisonkun & @justinmclean (remove SHOULD definition) --------- Co-authored-by: Arnout Engelen <arnout@engelen.eu> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * OF: http://svn.apache.org/viewvc => https Note: README files do not form part of the generated website * Workround for asfyaml newgen parsing bug Tested in preview/prevgen branch * Update members.md added myself (doebele) * Fix up recent changes to member status * Tidy up .asf.yaml (#463) No need for minimum_page_count work-round any more Drop profile from publish stanza (no longer tolerated by parser) Fix link to documentation * Update target lists Update the target mailing lists for some notification settings because site-cvs@apache.org does not seem to exist. This might need further tweaking. * Revert "Update target lists" Sorry, wrong repository This reverts commit 0932e44. * Add djoshi to members.md * Point security.txt to more 'guided' reporting instructions (#464) https://security.apache.org/report/ makes it clearer what to do when you want to report an issue with the ASF infrastructure, dependencies, or in our own code. * Update .htaccess, expose our CSP headers to fetch() * Remove legacy atom refs (#466) Signed-off-by: tison <wander4096@gmail.com> * home.a.o => people.a.o (#467) home is an alias for people, but is deprecated as a name. This is because it is not longer avaliable as a home for user files * Preview/paulau (#470) * adding asf initiatives page * updating initiatives content - removing member triggering build error * Restore cutting to file in emeritus section * Update sponsorship.md Updated with new ASF Initiatives copy approved by @bobpaulin * Ensure job failures are logged --------- Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: tison <wander4096@gmail.com> Co-authored-by: Brian Proffitt <bkp@apache.org> Co-authored-by: Imvedansh <113465074+Imvedansh@users.noreply.github.com> Co-authored-by: Imvedansh <ved17007@gmail.com> Co-authored-by: Sidney Markowitz <sidney@sidney.com> Co-authored-by: Dave Fisher <dave2wave@comcast.net> Co-authored-by: bob <bob@apache.org> Co-authored-by: Andrew Wetmore <andrew@cottage14.com> Co-authored-by: Rich Bowen <rbowen@rcbowen.com> Co-authored-by: Shane Curcuru <asf@shanecurcuru.org> Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: Mark Thomas <markt@apache.org> Co-authored-by: Junkai <jxue@pinterest.com> Co-authored-by: Twice <twice@apache.org> Co-authored-by: Gang Wu <ustcwg@gmail.com> Co-authored-by: GPK <gopidesupavan@gmail.com> Co-authored-by: Niall Pemberton <niall.pemberton@gmail.com> Co-authored-by: Arnout Engelen <arnout@engelen.eu> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rainer Döbele <rdoebele@users.noreply.github.com> Co-authored-by: Ruediger Pluem <rpluem@apache.org> Co-authored-by: Dinesh <djoshi@apache.org> Co-authored-by: Arnout Engelen <arnout@bzzt.net> Co-authored-by: Daniel Gruno <humbedooh@apache.org> Co-authored-by: Paul Au <paul@constantia.io> Co-authored-by: Melissa Logan (she/her) <melissalogan@apache.org>
The following discussions on members@ talked about urgent releases where the voting period was less than the normal 72 hours:
It is difficult to have a consensus on what an exceptional circumstance is. No-one has disagreed with urgent releases for publicly know security issues. However there was agreement from a number of people (and no disagreement) on the following points:
I've tried to encapsulate that in a new section in the release policy doc. However I'm not the best wordsmith so please feel free to improve