protocol/rpc: fix live stream cursor/reorg off-by-ones

[moodysalem]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

Three targeted refinements to RPC stream client logic: adjusted block fetching range calculation in ChainTracker, fixed filter validation index tracking in RpcClient to report correct error positions, and expanded reorg detection in data-stream to account for empty block states.

Changes

Cohort / File(s)	Summary
Block Fetching Range packages/protocol/src/rpc/chain-tracker.ts	Adjusted endBlockNumber computation from currentBlockNumber + batchSize to currentBlockNumber + batchSize - 1n, reducing the inclusive range per iteration by 1 block.
Filter Validation Index Tracking packages/protocol/src/rpc/client.ts	Changed index variable from const to let and now increments it within the validation loop, enabling error messages to report the actual zero-based position of failing filters instead of always 0.
Reorg Detection Logic packages/protocol/src/rpc/data-stream.ts	Extended reorg invalidation condition to also check against lastEmptyBlockNumber, broadening edge case handling for empty block scenarios during cursor advancement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Send empty RPC headers #204: Directly modifies packages/protocol/src/rpc/data-stream.ts with lastEmptyBlockNumber handling and reorg logic updates.
• protocol: rpc stream client #192: Updates ChainTracker and RpcClient functions that overlap with modifications in this PR's affected files.
• Reduce the number of RPC calls #203: Modifies ChainTracker's updateHead block-fetching behavior and related head-refresh logic.

Suggested reviewers

• fracek

Poem

🐰 Three tweaks through RPC streams we hop,
Block ranges refined, filters now stop,
At the right position to report their plight,
And reorg detection shines ever more bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description is empty, providing no details about the changes or their rationale.	Add a description explaining the off-by-one issues being fixed, their impact, and any testing performed to validate the fixes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main changes: fixing off-by-one errors in live stream cursor and reorg handling across the RPC protocol module.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}