CombatEvents: Convert namespace constants to enum class#4
Open
HamsterSerious wants to merge 3 commits intoapoguita:mainfrom
Open
CombatEvents: Convert namespace constants to enum class#4HamsterSerious wants to merge 3 commits intoapoguita:mainfrom
HamsterSerious wants to merge 3 commits intoapoguita:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted CombatEventTypes namespace with constexpr constants to a proper enum class CombatEventType : uint32_t for type safety
Added to_uint() helper function for easy conversion back to uint32_t
Added backwards-compatible CombatEventTypes namespace in the .cpp file with constexpr aliases mapping to the new enum values, so existing code using CombatEventTypes::FOO continues to work
Important Note
I haven't had time to work on this for the past week and upstream has had changes in the meantime. I've rebased on top of the latest upstream, but it would be appreciated if you could double-check that nothing was broken in the process.