Add play sound message

[tlf30]

I know that kotin-experiments is closed to new features. I am opening this for reference until kotlin-experiments is merged into master.

~Trevor

[garyttierney]

What unit is the delay measured in?

[tlf30]

I believe ticks

[garyttierney]

Do we know what the different types are?

[tlf30]

So far all the sounds I have used are using type 0

[garyttierney]

Could you update the documentation about the two things mentioned (delay in ticks, type usually 0). Besides that LGTM.

[tlf30]

@garyttierney I looked at the client I have a little. The delay is in milliseconds. The type I am not sure of though. It is passed to a function in the SoundTrack class called mix(int loop). I played several sounds doing a test of type 0, the of type 1. I could not hear any difference.

[garyttierney]

Ok. If the type is always 0 we should add a constructor that uses 0 as a default value.

[Major-]

Aren't there two different frames to play (different types?) of sound

[garyttierney]

There's music and there's sound effects IIRC.

[tlf30]

If someone can confirm which of the two channels are which, i.e channel 1 is music and 2 is sound effects. That is an example, I have no evidence for that. Then, I will work on adding sounds once kotlin experiments is merged. I have a list of sound effects and what they go to.

[tlf30]

OK, I believe that channel 0 is sound effects and channel 1 is music.
No idea, music is on its own channel

[codecov-io]

Codecov Report

Merging #370 into kotlin-experiments will decrease coverage by 0.03%.
The diff coverage is 0%.

@@                   Coverage Diff                    @@
##             kotlin-experiments     #370      +/-   ##
========================================================
- Coverage                 23.16%   23.12%   -0.04%     
  Complexity                  807      807              
========================================================
  Files                       643      645       +2     
  Lines                     11131    11146      +15     
  Branches                   1637     1637              
========================================================
  Hits                       2578     2578              
- Misses                     8268     8283      +15     
  Partials                    285      285

Impacted Files	Coverage Δ	Complexity Δ
...game/release/r377/SendPlaySoundMessageEncoder.java	0% <0%> (ø)	0 <0> (?)
.../java/org/apollo/game/release/r377/Release377.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...apollo/game/message/impl/SendPlaySoundMessage.java	0% <0%> (ø)	0 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c78ce...828cf12. Read the comment docs.