[RFC] Port of Ruby combat framework to Kotlin#376
Open
garyttierney wants to merge 11 commits intokotlin-experimentsfrom
Open
[RFC] Port of Ruby combat framework to Kotlin#376garyttierney wants to merge 11 commits intokotlin-experimentsfrom
garyttierney wants to merge 11 commits intokotlin-experimentsfrom
Conversation
Contributor
Author
|
My current TODO list for this (not counting the numerous |
garyttierney
force-pushed
the
kotlin-experiments
branch
from
5211b9b to
97896a3
Compare
garyttierney
added
medium
needs-discussion
This fixes the recording of projectile updates in a region.
garyttierney
force-pushed
the
kotlin-combat
branch
from
7e2ef0c to
0e98d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not in scope for the
kotlin-experimentsbranch, this is something I'd still like to get some feedback on. All of the basics are there for melee + ranged, including max hit / accuracy. The DSL itself is almost a one-to-one port of what was done in Ruby, with some Kotlin specifics to make the framework more idiomatic.See the Scimitar/Bow plugins for examples of how to configure new weapon classes and weapons.
ScimitarandBowareWeaponClassobjects that are defined bymelee_classes.ktandranged_classes.kt.