Add custom bounds implementation for game objects#408
Open
stevesoltys wants to merge 3 commits intoapollo-rsps:kotlin-experimentsfrom
Open
Add custom bounds implementation for game objects#408stevesoltys wants to merge 3 commits intoapollo-rsps:kotlin-experimentsfrom
stevesoltys wants to merge 3 commits intoapollo-rsps:kotlin-experimentsfrom
Conversation
stevesoltys
force-pushed
the
feature/game-object-bounds
branch
from
eca25f1 to
48f0d69
Compare
| * | ||
| * @return The set of interaction positions. | ||
| */ | ||
| private Set<Position> getInteractablePositions() { |
Contributor
There was a problem hiding this comment.
I need an example of this in use. I'm not sure that creating this Set all the time is optimal. Maybe roll this up into your distanced action changes?
Contributor
Author
There was a problem hiding this comment.
@garyttierney In the distanced action we provide an Entity and check the interaction positions of that entity to decide when to trigger the action for a Mob.
Here's an example: https://gist.github.com/stevesoltys/197e7a604f8bfe495ae070c2db0c89c1
Contributor
Author
There was a problem hiding this comment.
Note that in my example, I've made the getInteractionPositions method abstract in EntityBounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a review request for now, unless the other contributors are interested in merging this before the remaining object types are supported. Apollo should be capable of supporting an updated
DistancedActiononce this functionality is available.This PR in its current state is capable of getting the interaction positions for (AFAIK) all types of
GameObjectthat are being used today in Apollo's plugins.