Add Essence Mining#424
Open
Tomm0017 wants to merge 15 commits intoapollo-rsps:kotlin-experimentsfrom
Tomm0017:essence_mining
Open
Add Essence Mining#424Tomm0017 wants to merge 15 commits intoapollo-rsps:kotlin-experimentsfrom Tomm0017:essence_mining
Tomm0017 wants to merge 15 commits intoapollo-rsps:kotlin-experimentsfrom
Tomm0017:essence_mining
Conversation
added 12 commits
April 25, 2019 05:54
The message sent when player does not have a pickaxe they can use should be sent only after the player has reached the rock.
added 3 commits
April 25, 2019 06:29
Renamed to avoid conflict between the const and enum declaration
Ores that do not contain an item id or do not deplete will never pass the current tests
Codecov Report
@@ Coverage Diff @@
## kotlin-experiments #424 +/- ##
========================================================
+ Coverage 23.23% 23.23% +<.01%
Complexity 811 811
========================================================
Files 643 643
Lines 11123 11130 +7
Branches 1632 1637 +5
========================================================
+ Hits 2584 2586 +2
- Misses 8251 8252 +1
- Partials 288 292 +4
Continue to review full report at Codecov.
|
Member
|
Looks great (sorry for the enormous delay in reviewing this), needs tests for the essence mining though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #184 where support for mining Rune and Pure essence is requested