Somewhat hacky method to add applicationPeriod.end 2 hours later #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
julian-ao
reviewed
Aug 25, 2024
| useEffect(() => { | ||
| const startDate = fromDate ? `${fromDate}T00:00` : ""; | ||
| const endDate = toDate ? `${toDate}T23:59` : ""; | ||
| const startDate = fromDate ? `${fromDate}T02:00` : ""; |
Member
There was a problem hiding this comment.
hvorfor 2 på natta på startDate?
julian-ao
reviewed
Aug 25, 2024
Comment on lines
+14
to
+21
| let endDate = toDate ? `${toDate}T00:00` : ""; | ||
|
|
||
| if (endDate) { | ||
| const endDateObj = new Date(endDate); | ||
| endDateObj.setDate(endDateObj.getDate() + 2); | ||
| endDateObj.setHours(endDateObj.getHours() - 22); | ||
| endDate = endDateObj.toISOString(); | ||
| } |
Member
There was a problem hiding this comment.
trenger vi alt dette? kan vi ikke bare bruke endDate og sette dagen til +1?
noe sånn:
Suggested change
| let endDate = toDate ? `${toDate}T00:00` : ""; | |
| if (endDate) { | |
| const endDateObj = new Date(endDate); | |
| endDateObj.setDate(endDateObj.getDate() + 2); | |
| endDateObj.setHours(endDateObj.getHours() - 22); | |
| endDate = endDateObj.toISOString(); | |
| } | |
| constendDate = toDate ? `${toDate}T02:00` : ""; | |
| if (endDate) { | |
| endDate.setDate(endDateObj.getDate() + 1); | |
| } |
Også bare toISOString() på start og end date før de returneres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.