[BE-4789]: Initially fixed for wf step templates#731
Conversation
✅ Deploy Preview for reverent-galileo-8ef035 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ftmzhrsckldr I updated all WF step docs to have the same template.The changes were applied to each step so that the templates of all step documents are the same. Please check here before you start the review. Looking at these before you start will help us to spot any logical errors or mistakes early on and avoid wasting time. Because most of the changes are the same and repetitive. What has changed? 1- All required Prequisites introduction sentences have been changed as follows. 2- Corrected the formatting of all info, caution, danger etc boxes in the .md file. 7- Duplicated post processor step doc has been deleted. 10- Replaced the introductory sentences of all output headers with this one. 11- The introductory sentence under the prerequisites heading for steps without prerequisites has been replaced with the following. Note: I have not change anything in Saucectl doc. Because we already have new version of it in this PR. |
@boztopuz I did not see any problems with what was commented. However, after reviewing the documents, if one of the templates we used does not match that document, I can add feedback. For example, if the warn message you gave in step 6 does not match the variable that should be secret in the doc, I can add feedback. Other than that, I did not see any problems. By the way, there were errors in document linking in old documents. Instead of internal linking, there were links starting with "http...". Were you able to check these as well? |
@ftmzhrsckldr Unfortunately, I did not check the links which include http...., I will try to check as soon as possible all of them today. |
|
@boztopuz I will make a checklist of the list you shared. To make sure I have changed the necessary points in each document. While doing this, I have a few questions: 2- Corrected the formatting of all info, caution, danger etc boxes in the .md file.What do you mean by formatting? 5- Removed output section in docs for the steps that has not output variables.There are documents where I added the 8- All FAQ headings have been edited.Is this what you mean by that?
Is there anything else I should check other than that? |
Old version of document danger info etc boxes are like this in md files I changed all of these like The reason I do this is that some errors can occur in the docs when using non-space format. We have experienced this in the past
When you look at the documents, you will see that I did not delete all of them, I deleted only the sections that do not have a table and a specific description.
Yes that is true, I changed the faq sections like
|
docs/workflows/android-specific-workflow-steps/android-build.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/android-dependency-report.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/android-unit-tests.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/android-build-for-ui-testing.md
Show resolved
Hide resolved
docs/workflows/ios-specific-workflow-steps/install-certificates-provisions.md
Outdated
Show resolved
Hide resolved
docs/workflows/ios-specific-workflow-steps/xcodebuild-for-unit-and-ui-test.md
Show resolved
Hide resolved
docs/workflows/react-native-specific-workflow-steps/npm-yarn-commands.md
Outdated
Show resolved
Hide resolved
Feedback Summary@boztopuz The initial documents were very well-prepared and required minimal feedback. However, as we progressed, the amount of feedback increased. I believe having too many changes in a single PR might have reduced focus. I structured my feedback so that you can directly apply the suggestions if you approve them. However, for some unchanged paragraphs, GitHub did not allow me to add feedback. In those cases, I made corrections by linking them to the nearest editable line. Feedback Summary
CC: @csonuryilmaz |
docs/workflows/ios-specific-workflow-steps/appdome-build-to-secure-for-ios.md
Outdated
Show resolved
Hide resolved
docs/workflows/ios-specific-workflow-steps/xcodebuild-for-devices.md
Outdated
Show resolved
Hide resolved
docs/workflows/ios-specific-workflow-steps/xcodebuild-for-devices.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/appsweep-mobile-security-testing.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/android-unit-tests.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/android-unit-tests.md
Outdated
Show resolved
Hide resolved
docs/workflows/android-specific-workflow-steps/app-center-android-distribution.md
Outdated
Show resolved
Hide resolved
|
The vast majority of feedback has been implemented correctly. @boztopuz Note: One of my previous feedback I marked unresolved. FYI |
No description provided.