Conversation
✅ Deploy Preview for reverent-galileo-8ef035 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
csonuryilmaz
left a comment
There was a problem hiding this comment.
File has some duplicate from URLs. There should be only one redirection for a path.
2 from = "/integrations/working-with-custom-scripts/"
2 from = "/workflows/android-specific-workflow-steps/build-and-test/android-build"
2 from = "/workflows/common-workflow-steps/build-and-test/publish-release-notes"
2 from = "/workflows/ios-specific-workflow-steps/distribution/browserstack-app-automation"
csonuryilmaz
left a comment
There was a problem hiding this comment.
🧪 Tests
- ✅ There should be no
forceoption usage in redirects. - ✅ All redirects should have
301redirected status code. - ✅ There should be no duplicate redirect
fromin the list. - ✅ All redirects should end with
200andtopage as defined. - ✅ There should be no circular redirect. (
from==tocase)
Disclaimer
The code review and test done in this PR checks all redirects are working as defined in the Netlify configuration file, and they're correctly defined as in Netlify documents. But it does not include any semantic checks.
For instance, if the Px is redirected to the page Py but it should have been redirected to Pz, this case is not included. When Py is an existing page and the user enters Px in the browser, the user is redirected to Py; it's 🆗 in the tests.
Reason (or assumption) is that all redirects were checked atomically in the context when they were merged first time in the previous PRs, so the redirects should have been correct semantically.
No description provided.