feat(setup): how to install on OpenShift cluster#803
Merged
csonuryilmaz merged 7 commits intodevelopfrom Feb 14, 2025
Merged
Conversation
✅ Deploy Preview for reverent-galileo-8ef035 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
csonuryilmaz
suggested changes
Feb 12, 2025
Contributor
csonuryilmaz
left a comment
csonuryilmaz
left a comment
There was a problem hiding this comment.
@Alnyli07 we have some notes on the PR that should be handled.
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
hiilhan
reviewed
Feb 13, 2025
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
|
|
||
| If you are deploying the Appcircle server for a production environment, it is recommended that stateful applications, such as databases or object storage, be deployed outside the scope of the Appcircle server Helm chart. | ||
|
|
||
| For more information, you can check the [Production Readiness](/self-hosted-appcircle/install-server/helm-chart/configuration/production-readiness) documentation. |
Contributor
There was a problem hiding this comment.
Should this be after step "3. Create Namespace" ?
|
|
||
| If you are deploying the Appcircle server for a production environment, it is recommended that stateful applications, such as databases or object storage, be deployed outside the scope of the Appcircle server Helm chart. | ||
|
|
||
| For more information, you can check the [Production Readiness](/self-hosted-appcircle/install-server/helm-chart/configuration/production-readiness) documentation. |
Contributor
There was a problem hiding this comment.
Production Readiness page has instructions to update values.yaml but we didn't create it here yet. It is first mentioned at a later title:
Installation / 1. Create
values.yaml
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
docs/self-hosted-appcircle/install-server/helm-chart/installation/openshift.md
Outdated
Show resolved
Hide resolved
- Replaced 'namespace' with 'project' to align with OpenShift terminology. - Updated `kubectl` commands to `oc` commands for better compatibility. - Changed 'Ingress' references to 'Route' in OpenShift context. - Specified OpenShift 4.12+ as the minimum required version. - Adjusted Helm installation instructions to use `--namespace` instead of `-n`.
csonuryilmaz
approved these changes
Feb 14, 2025
Contributor
csonuryilmaz
left a comment
csonuryilmaz
left a comment
There was a problem hiding this comment.
@hiilhan Some of your comments seem to be fixed by Osman while improving documentation. We have some other unresolved comments there that also include yours.
We will handle them in a future issue on our side.
github-actions
bot
added
the
autoupdate
csonuryilmaz
removed
the
autoupdate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install appcircle with helm on OpenShift Cluster.