Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 5, 2023

I goofed and cloned the appdev-project and not my own. I also added a new file 'public/styles.css' and I'll delete it and create a pull request for that, too.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This initial markup provides a solid and clear foundation for the Rock-Paper-Scissors interface. The positive aspects are its simplicity and adherence to basic HTML structure, including setting the document title and character encoding. The purpose of the three links is immediately obvious, which is great for user flow. However, I have a few suggestions for improvement. Semantically, since "Play Rock," "Play Paper," and "Play Scissors" are actions rather than navigation targets, they should ideally be implemented using elements instead of tags, assuming that JavaScript will handle the game logic without navigating away from the page. If you stick with tags, the current hardcoded paths (/rock, /paper) are fine, but they indicate a multi-page app, which might be overkill for this simple game. Finally, the page is currently missing any CSS or visual styling. The next steps should focus on introducing responsive Tailwind classes or custom CSS to enhance the user experience and adding the necessary JavaScript logic to make the game fully functional by tracking choices, determining the winner, and updating the score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant