Skip to content

Link the create command from manifests page #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daxelrod wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Link the create command from manifests page #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/manifests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Rather than using scripts AppGet uses `YAML` files to define application package

All available packages are hosted in our official [GitHub Repository](https://github.com/appget/appget.packages). You can review and propose changes to any of the manifests using a pull-request.

To create a new manifest and propose its addition to the repository, use the [`create` command](/commands/#create).
Copy link
Author

@daxelrod daxelrod Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path structure should work on https://docs.appget.net/ but won't work correctly when browsing this repo locally. I'm open to other ideas for how to construct this path.

Copy link

@Conan-Kudo Conan-Kudo Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you leave off the leading slash, it's supposed to work as a relative path, I think?

Copy link
Author

@daxelrod daxelrod Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving off the trailing slash is another option that works on docs.appget.net but not when browsing the repo locally, since manifests is a directory. There may not be a link scheme that works in both, but I was highlighting this because I don't know that the intended style in this repo is.


For example, [vlc.yaml](https://github.com/appget/appget.packages/blob/master/manifests/vlc/vlc.yaml)

```yaml
Expand Down