Skip to content

LinuxContainer: Give a bit of overhead memory #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcantah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LinuxContainer: Give a bit of overhead memory #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Sources/Containerization/LinuxContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,22 @@ extension LinuxContainer {
var modifiedRootfs = self.rootfs
modifiedRootfs.options.removeAll(where: { $0 == "ro" })

// Calculate VM memory with overhead for the guest agent.
// The container cgroup limit stays at the requested memory, but the VM
// gets an additional 50MB for the guest agent (could be higher, could be lower
// but this is a decent baseline for now).
//
// Clamp to system RAM if the total would exceed it as Virtualization.framework
// bounds us to this.
let guestAgentOverhead: UInt64 = 50.mib()
let vmMemory = min(
self.memoryInBytes + guestAgentOverhead,
ProcessInfo.processInfo.physicalMemory
)

let vmConfig = VMConfiguration(
cpus: self.cpus,
memoryInBytes: self.memoryInBytes,
memoryInBytes: vmMemory,
interfaces: self.interfaces,
mountsByID: [self.id: [modifiedRootfs] + self.config.mounts],
bootLog: self.config.bootLog,
Expand Down