Open
Conversation
codercatdev
requested review from
Meldiron,
christyjacob4 and
lohanidamodar
Closed
lohanidamodar
requested changes
Oct 28, 2022
Member
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Hey, it looks great. Just a spacing change and small query.
| - [Generate API Key](http://localhost/console/keys?project=playground) | ||
| - In `./helpers/setup.js` update the `setKey` method with your new value | ||
| - Run command `node ./helpers/setup.js` | ||
| ## Get Started |
Member
There was a problem hiding this comment.
Suggested change
| ## Get Started | |
| ## Get Started |
| let users = new sdk.Users(client); | ||
|
|
||
| let promise = users.get('623b66a849afa34b5d4e'); | ||
| let promise = users.get("6334bfa0202f3a501716"); |
Member
There was a problem hiding this comment.
Why is this ID hardcoded, what are we testing here? and why did this required an update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates to v1.0
Test Plan
Run test against your local instance
Related PRs and Issues
#68 Upgrade
Have you read the Contributing Guidelines on issues?
yes