Netzgestaltung patch edit field js#96
Open
netzgestaltung wants to merge 3 commits intoaprokopenko:developfrom
Open
Netzgestaltung patch edit field js#96netzgestaltung wants to merge 3 commits intoaprokopenko:developfrom
netzgestaltung wants to merge 3 commits intoaprokopenko:developfrom
Conversation
Fix simple media shortcode empty value, Gutenberg compatibility
WordPress 5.5 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
reference: https://wordpress.org/support/topic/cannot-add-a-new-field/#post-14035053
Problem:
the problem is inside the JS construction at
/just-custom-fields/assets/just_custom_fields.jsbefore there was the old live function for the submit event handler of the “edit field” form. it took care of elements with the same selector to be attached to the event handler even if its created after the attachment (by an ajax call) which is the case here.
i encapsuled the event handler in a new seperate function
jcf_init_edit_fieldapart frominitFieldsetFieldsand added it to the promise handler of the ajax responsejcf_show_ajax_container