[WIP] Add routeType attribute & logic to attempt static routes before parameterized routes#6
Open
naqll wants to merge 2 commits intoaquasecurity:masterfrom
Open
[WIP] Add routeType attribute & logic to attempt static routes before parameterized routes#6naqll wants to merge 2 commits intoaquasecurity:masterfrom
naqll wants to merge 2 commits intoaquasecurity:masterfrom
Conversation
ido50
suggested changes
Jun 10, 2021
Contributor
ido50
left a comment
There was a problem hiding this comment.
Hi. Thank you for this contribution to the project. Can you please update the unit tests after this change? They are now failing.
Thanks again.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue can be found here.
A WIP POC to attempt static routes before those containing a parameter. This would allow overlapping routes to function as intended.
Example:
GET /users/:useridGET /users/history