Open
Conversation
added 6 commits
July 28, 2023 16:44
zak39
reviewed
Jul 28, 2023
Collaborator
zak39
left a comment
zak39
left a comment
There was a problem hiding this comment.
Can you create a script in the package.json to run the nightwatch, please ?
Thank you for your job !!!! 😉
tests/nightwatch/login.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| describe('Login into nextcloud end-to-end test', function() { | |||
Collaborator
There was a problem hiding this comment.
Can you replace 'Login into nextcloud end-to-end test' by `Chek if the workspace app is present', please ?
tests/nightwatch/login.js
Outdated
| describe('Login into nextcloud end-to-end test', function() { | ||
| before(browser => browser.navigateTo(browser.launchUrl)) | ||
|
|
||
| it('arrives on the home page and submits credentials with login form', function(browser) { |
Collaborator
There was a problem hiding this comment.
Can you replace arrives on the home page and submits credentials with login form by login as admin, please ?
tests/nightwatch/login.js
Outdated
| .setValue('input#password', browser.globals.adminPwd) | ||
| .click('button[type=submit]') | ||
| }) | ||
| it('verifies that workspace icon is present', function(browser) { |
Collaborator
There was a problem hiding this comment.
Can you replace 'verifies that workspace icon is present' by check that workspace icon is present please ?
tests/nightwatch/wsManagement.js
Outdated
| @@ -0,0 +1,29 @@ | |||
| describe('Create, rename and remove workspaces', function() { | |||
Collaborator
There was a problem hiding this comment.
Can you split in three describes please ?
Create workspacesRename workspacesRemove workspaces
added 2 commits
July 31, 2023 11:23
divided wsManagement tests in two describe blocks, added indentations and improved descriptions in login.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR contains almost the same code as test/nightwatch-e-2-e-tests except that it uses Nightwatch v. 3.1.1 and launchUrl variables in place of the hardcoded url parameters