Skip to content

Don't ack within 'read' if we are having a callback registered and reading from within the callback#45

Open
aentinger wants to merge 1 commit intomasterfrom
fix-dont-ack-if-reading-in-callback
Open

Don't ack within 'read' if we are having a callback registered and reading from within the callback#45
aentinger wants to merge 1 commit intomasterfrom
fix-dont-ack-if-reading-in-callback

Conversation

@aentinger
Copy link
Contributor

@aentinger aentinger commented Jul 28, 2020

Otherwise ACK is sent twice - once during read and once after the completion of the callback _onMessage handler.

@aentinger aentinger added the type: imperfection Perceived defect in any part of project label Jul 28, 2020
@aentinger aentinger requested a review from facchinm July 28, 2020 13:50
@aentinger aentinger self-assigned this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@aentinger aentinger

Labels

type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aentinger