Add support for Atlas CLI CE edition and add AllowDirty option #307
+60
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AllowDirty field to allow applying migrations to databases with schemas not managed by Atlas (e.g., system schemas in TiDB/MySQL).
Handle atlasexec.ErrRequireEnterprise to support Atlas Community Edition. Remove requiresCloudLogin() helpers and isCommunityErr() detection. Simplify WhoAmI error handling to use wrapped Atlas CLI errors directly. Community Edition is now treated as Enterprise Edition without cloud login, with proper error messages from Atlas CLI including installation instructions.
Use single Dockerfile with ATLAS_IMAGE build arg to support both editions. Remove redundant Dockerfile.community and update workflows to use unified build with appropriate build args.
Member
|
Thanks for the PR. Please, see my comment here: ariga/atlas#3640 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Atlas Operator didn't work with TiDB due to it using Atlas EE which does something with MySQL vector extensions and fails to do anything with TiDB. I tried to change Atlas Operator to use Atlas CE but encountered some issues. This PR fixes those and depends on changes to atlasexec from ariga/atlas#3640 to communicate CE vs EE Atlas CLI differences (mainly lack of
atlas whoami)