add deepin-loongarch64 libmupdf.so lib and modify build.sh to adapt l…#33
Open
GithubXkw1573 wants to merge 1 commit intoarklumpus:masterfrom
Open
add deepin-loongarch64 libmupdf.so lib and modify build.sh to adapt l…#33GithubXkw1573 wants to merge 1 commit intoarklumpus:masterfrom
GithubXkw1573 wants to merge 1 commit intoarklumpus:masterfrom
Conversation
Owner
|
Hi, thank you for the contribution! Unfortunately, I don't think I can merge this in the main repository, for two main reasons:
My advice would be for you to create a separate GitHub repository with the loongarch64 native assets, and upload yourself the MuPDF.NativeAssets.Linux-loongarch64 to NuGet. Note that there are a couple of places in your pull request where Linux-x64 is still referenced rather than Linux-loongarch64 - you should probably fix these. I can then add a note to the main MuPDFCore repository stating that Linux-loongarch64 is unofficially supported thanks to [your repository]. I hope this makes sense, and thank you again for putting the work in this! |
Author
|
OK,I got it, it should be scientific to verify it by yourself on loongson cpu . I will check those places where Linux-x64 is still referenced rather than Linux-loongarch64 what you noted , thank you!And I will take your advice to create a separate GitHub repository and upload MuPDF.NativeAssets.Linux-loongarch64 to NuGet. Thank you for your reply, and best wishes for you! Good night.————————发自我的 iPhone在 2024年6月27日,23:03,Giorgio Bianchini ***@***.***> 写道:
Hi, thank you for the contribution! Unfortunately, I don't think I can merge this in the main repository, for two main reasons:
Since I do not have access to a loongson CPU, I would not be able to recompile things if I needed to apply any updates.
I am also not really comfortable with hosting and distributing binaries that I did not compile personally (especially in the light of recent events, like the XZ Utils backdoor incident).
My advice would be for you to create a separate GitHub repository with the loongarch64 native assets, and upload yourself the MuPDF.NativeAssets.Linux-loongarch64 to NuGet. Note that there are a couple of places in your pull request where Linux-x64 is still referenced rather than Linux-loongarch64 - you should probably fix these. I can then add a note to the main MuPDFCore repository stating that Linux-loongarch64 is unofficially supported thanks to [your repository].
I hope this makes sense, and thank you again for putting the work in this!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#linux-loongarch64 support
I Compiled the dependency of libmupdf.a and libmupdf-third.a on loongarch64 GNU/Linux
and then modifed the native/build.sh to support loongarch64
and compile and output the libMuPDFWrapper.so, so that can run loongarch64 platform and I have test it run successful !