Skip to content

Add find-duplicates feature #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artem-y merged 17 commits into from
Dec 31, 2024
Merged

Add find-duplicates feature #21

artem-y merged 17 commits into from
Dec 31, 2024

Conversation

@artem-y
Copy link
Owner

@artem-y artem-y commented Dec 31, 2024 •
edited
Loading

In this PR

  • bumped ArgumentParser dependency version to 1.5.0
  • split the main command into two subcommands, making find-color the default one to preserve existing functionality
  • added new find-duplicates command to enable search for duplicated color assets
  • renamed a few of the existing methods to make the difference more explicit
  • covered the logic with new unit and end-to-end tests, also committed one of the performance tests
  • mentioned updates in README
  • bumped the app version to 0.2.0 in the command configuration

Checklist

Before making this PR ready to merge:

  • Checked for duplicate PRs
  • If related to one or more existing issues, linked the issues
  • Covered new code with unit tests
  • Ran the tests and all of them passed

artem-y added 17 commits December 25, 2024 21:33
@artem-y
Add basic end-to-end tests for find-duplicates subcommand
57927a3
@artem-y
Bump argument parser version to 1.5.0
c915112
@artem-y
Split main command into subcommands, add empty find-duplicates command
f872250
@artem-y
Connect color finder to the search for duplicates
173b664
@artem-y
Change app version to feature branch name
9ed5a66
@artem-y
Implement logic for finding duplicates
20bb539
@artem-y
Remove deprecated URL init
679dd13
@artem-y
Include path in the color name
f4bc6c2
@artem-y
Add separator between duplicates
c403d98
@artem-y
Add tests for more cases of find-duplicates command logic
11b0a9a
@artem-y
Improve the speed of performing find-duplicates command
50de54d
@artem-y
Reuse colorset name creation code
03c84de
@artem-y
Add safety check for invalid color componentswhen comparing duplicates
718a808
@artem-y
Include find-duplicates command performance test in the repo
8030b26
@artem-y
Prevent out-of-bounds exception when there are no color assets
d1e142b
@artem-y
Update README.md with find-duplicates command description
3ae2e25
@artem-y
Bump version to 0.2.0 in configuration
ec47c7e
@artem-y artem-y added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 31, 2024
@artem-y artem-y self-assigned this Dec 31, 2024
@artem-y artem-y merged commit 5beccc2 into main Dec 31, 2024
1 check passed
@artem-y artem-y deleted the feature/find-duplicates branch December 31, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@artem-y artem-y

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artem-y