Fix #71; Align visual click behavior with Industry Standard#74
Open
modellking wants to merge 10 commits intoarthurmatthew:mainfrom
Open
Fix #71; Align visual click behavior with Industry Standard#74modellking wants to merge 10 commits intoarthurmatthew:mainfrom
modellking wants to merge 10 commits intoarthurmatthew:mainfrom
Conversation
…le a pitch change on the down- and backbeat + Added Metronome.accent UI
* changed callback to onClick, triggering on every pulse * shortened the visual click animation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
+ whitenoise click source
Owner
|
Hey, I appreciate the development! I haven't worked on this project in a while but I was planning on finishing it up soon. I need to regain my bearings with the project and I'll check out your pull request further when that time comes! |
Author
|
If you do not mind, I'd submit a few pull-requests for some features (including some UX changes) that turned out to be relevant in our chruch. I'd be happy to chat about some ideas if that's an option? |
Owner
|
Yeah, for sure! It would probably be easiest to open up a discussion inside of this repository, I assume? |
Author
|
Sure, I haven't used github too much, but that seems to be the right place |
Refactored Sounds to be a generic Repository
Added UI to switch the click sound some simplifications Fixed Noise Click Small Css Adjustments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Options to toggle Pitch Click variations
Moved Visual Click on all Clicks