Skip to content

chore: use rn-launch-arguments new architecture supported version#12656

Merged
MounirDhahri merged 1 commit intomainfrom
chore/upgrade–react-native-launch-arguments
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "chore/upgrade\u2013react-native-launch-arguments"
Merged

chore: use rn-launch-arguments new architecture supported version#12656
MounirDhahri merged 1 commit intomainfrom
chore/upgrade–react-native-launch-arguments

Conversation

@MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Aug 20, 2025

in-progress

This PR resolves PHIRE-2084

Description

This PR updates react-native-lauch-arguments to use our new architecture + old architecture implementation.

Fwiw, I also opened a PR to add support of the new architecture in the original repo here iamolegga/react-native-launch-arguments#84. I had to timebox this because there were other parts in the original repo that were outdated that I didn't get to upgrade (ts and example project rn version)

Build succeeding on new architecture on Energy
Screenshot 2025-08-20 at 17 55 07
Screenshot 2025-08-20 at 17 55 01

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshotsor videosat least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up workthat this PR will require, or it does not require any.
  • I have added a changelog entrybelow, or my changes do not require one.

To the reviewers 👀

  • I would like at least oneof the reviewers to runthis PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • use rn-launch-arguments new architecture supported version - mounir

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Aug 20, 2025
@MounirDhahri MounirDhahri force-pushed the chore/upgrade–react-native-launch-arguments branch from c374200 to 657af8b Compare August 21, 2025 09:17
@MounirDhahri MounirDhahri marked this pull request as ready for review August 21, 2025 12:45
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (use rn-launch-arguments new architecture supported version - mounir - MounirDhahri)

Generated by 🚫 dangerJS against 657af8b

@MounirDhahri MounirDhahri merged commit 38291bf into main Aug 26, 2025
8 checks passed
@MounirDhahri MounirDhahri deleted the chore/upgrade–react-native-launch-arguments branch August 26, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants