Skip to content

Conversation

@erikdstock
Copy link
Contributor

@erikdstock erikdstock commented Jan 28, 2026

The type of this PR is: fix

This PR solves EMI-3047 by fixing several express checkout issues:

  • It removes a non-null assertion that was breaking shipping address setting and the entire subsequent flow.
  • It makes the order mutation and submission flow match what we have in our normal checkout, avoiding the need to fork our logic in exchange in https://github.com/artsy/exchange/pull/2909#discussion_r2732197818
  • It encapsulates logic for the callbacks passed to the express checkout element to account for differences between apple and google pay.

Testable at https://express-checkout-test.artsy.net

cc @artsy/emerald-devs

@erikdstock erikdstock self-assigned this Jan 28, 2026
@relativeci
Copy link

relativeci bot commented Jan 28, 2026

#6272 Bundle Size — 9.2MiB (+4.52%).

cf24853(current) vs 9eecfa0 main#6268(baseline)

Important

Bundle introduced 10 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 43 new packages: @artsy/xapp, node-uuid, crypto-browserify and 40 more – View changed packages

Bundle metrics  Change 9 changes Regression 4 regressions
                 Current
#6272
     Baseline
#6268
Regression  Initial JS 3.5MiB(+12.77%) 3.11MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 50.45% 0%
Change  Chunks 99(-1%) 100
Change  Assets 102(-0.97%) 103
Change  Modules 5806(+2.93%) 5641
Regression  Duplicate Modules 560(+0.36%) 558
Change  Duplicate Code 3.88%(-1.27%) 3.93%
Regression  Packages 308(+20.78%) 255
Regression  Duplicate Packages 41(+32.26%) 31
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#6272
     Baseline
#6268
Regression  JS 9.07MiB (+4.61%) 8.67MiB
Improvement  Other 139.59KiB (-0.78%) 140.68KiB

Bundle analysis reportBranch erik.emi3047-submit-payment-meth...Project dashboard


Generated by RelativeCIDocumentationReport issue

@erikdstock erikdstock changed the title fix(EMI-3047]: Express checkout shipping address and submission fix(EMI-3047): Express checkout shipping address and submission Jan 28, 2026
Comment on lines +211 to +215
return {
order,
shippingRates: extractShippingRates(order),
lineItems: extractLineItems(order),
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of our set_ helpers return this shape (maybe it should be a type) but now the act of setting a shipping address automatically triggers the next step for google pay because it does not automatically do so.

@erikdstock erikdstock changed the title fix(EMI-3047): Express checkout shipping address and submission fix(EMI-3047): Express checkout bugs Jan 29, 2026
@erikdstock erikdstock merged commit 15c9b78 into main Jan 29, 2026
17 checks passed
@erikdstock erikdstock deleted the erik.emi3047-submit-payment-method-with-order branch January 29, 2026 15:44
@artsy-peril artsy-peril bot mentioned this pull request Jan 29, 2026
id: orderData.internalID,
paymentMethod: "CREDIT_CARD",
creditCardWalletType,
stripeConfirmationToken: confirmationToken.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants