-
Notifications
You must be signed in to change notification settings - Fork 148
fix(EMI-3047): Express checkout bugs #16691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EMI-3047): Express checkout bugs #16691
Conversation
#6272 Bundle Size — 9.2MiB (+4.52%).cf24853(current) vs 9eecfa0 main#6268(baseline) Important Bundle introduced 10 duplicate packages – View changed duplicate packages Warning Bundle introduced 43 new packages: @artsy/xapp, node-uuid, crypto-browserify and 40 more – View changed packages Bundle metrics
Bundle size by type
Bundle analysis report Branch erik.emi3047-submit-payment-meth... Project dashboard Generated by RelativeCI Documentation Report issue |
| return { | ||
| order, | ||
| shippingRates: extractShippingRates(order), | ||
| lineItems: extractLineItems(order), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both of our set_ helpers return this shape (maybe it should be a type) but now the act of setting a shipping address automatically triggers the next step for google pay because it does not automatically do so.
src/Apps/Order2/Routes/Checkout/Components/ExpressCheckout/Order2ExpressCheckoutUI.tsx
Outdated
Show resolved
Hide resolved
src/Apps/Order2/Routes/Checkout/Components/ExpressCheckout/Order2ExpressCheckoutUI.tsx
Show resolved
Hide resolved
src/Apps/Order2/Routes/Checkout/Components/ExpressCheckout/Order2ExpressCheckoutUI.tsx
Outdated
Show resolved
Hide resolved
src/Apps/Order2/Routes/Checkout/Components/ExpressCheckout/Order2ExpressCheckoutUI.tsx
Outdated
Show resolved
Hide resolved
| id: orderData.internalID, | ||
| paymentMethod: "CREDIT_CARD", | ||
| creditCardWalletType, | ||
| stripeConfirmationToken: confirmationToken.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
The type of this PR is: fix
This PR solves EMI-3047 by fixing several express checkout issues:
Testable at https://express-checkout-test.artsy.net
cc @artsy/emerald-devs