fix: correct _default_value_for_type for temporal and unsupported types#36
Merged
xmnlab merged 2 commits intoarxlang:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
|
@yogendra-17 thanks for working on that cheers |
Contributor
|
arx uses pre-commit hooks .. you can install it locally running |
Contributor
Author
|
@xmnlab , i am sorry for missing that ...i have pushed the changes |
xmnlab
approved these changes
Mar 9, 2026
Contributor
|
thanks @yogendra-17 ! appreciate it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
_default_value_for_typesilently returnedLiteralInt32(0)for any unrecognised type, including fully-supported temporal types likeDateTime,Timestamp,Date, andTime. This produced incorrect AST nodes with no indication of the problem.How to test these changes
Updated
test_parse_type_list_and_default_valuesto assert correct literal types are returned for all temporal types, and added apytest.raises(ParserException)assertion forListType....Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: