feat: add LLVM IR codegen for StructDefStmt and tests#201
feat: add LLVM IR codegen for StructDefStmt and tests#201m-akhil-reddy wants to merge 7 commits intoarxlang:mainfrom
Conversation
|
@m-akhil-reddy , i thought you were working on @omsherikar branch, wasnt it? or this is the branch you both will be working on with, so i can close one PR |
|
@yuvimittal , i am wrking in the new branch. i think you can close the other PR. |
|
Hi @yuvimittal , i have made PR for the issue #143 and can please review it , suggest me any changes if needed. Approach :-
Testing :-
|
|
@m-akhil-reddy , can we have one more test or it will reduce test coverage, rest looks good to me, good work! |
f7e56cc to
644ef10
Compare
|
@yuvimittal , Thank you for the feedback. I have added an additional test case for a struct with a single field to improve test coverage. Could you please review the changes and if you accept it then i can work on #152 #159 issues. |
Notes
you work. When you’re ready for a review, change the status to Ready for
review to trigger a new review round. If you make additional changes and
don’t want to trigger the bot, switch the PR back to Draft.
share your feedback; it helps us improve the tool.
as possible to increase the chances of a timely review. Large PRs may not be
reviewed and may be closed.
self-documenting
(guidance).
our Discord to discuss ideas, blockers, or issues
(https://discord.gg/Nu4MdGj9jB).
sensitive data/PII in code, configs, logs, screenshots, or commit history. If
something leaks, rotate the credentials immediately, invalidate the old key,
and note it in the PR so maintainers can assist.
needed for tests, prefer small fixtures or programmatic downloads declared in
makim.yaml (e.g., a task that fetches data at test time). If a large binary is
unavoidable, discuss first and consider Git LFS.
Pull Request description
#143
How to test these changes
...Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: