fix: default vector int division to signed to match scalar behavior#205
Open
Jaskirat-s7 wants to merge 1 commit intoarxlang:mainfrom
Open
fix: default vector int division to signed to match scalar behavior#205Jaskirat-s7 wants to merge 1 commit intoarxlang:mainfrom
Jaskirat-s7 wants to merge 1 commit intoarxlang:mainfrom
Conversation
11 tasks
Member
|
@Jaskirat-s7 , could u explain more about the pr please |
Contributor
Author
|
Hi @yuvimittal, This PR fixes Issue #204 (Inconsistent integer division signedness fallback between scalar and vector operands).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug reported in the issue regarding inconsistent astx.BinaryOp signedness fallback between scalar and vector operands.
Changes Made:
Updated the vector integer division logic in src/irx/builders/llvmliteir.py to default to unsigned = False (signed division via sdiv) when the unsigned attribute is omitted or set to None.
This unifies the vector fallback logic with the existing scalar fallback behavior and prevents the compiler from throwing an unexpected fatal Exception.
(Tested locally and verified against the existing AST constraint test suite).